NEVER HAD MUCH OF A FETISH about diving kit. Its primarily a tool that allows me to do what I love and see the things I am obsessive about - marine life. I want kit that doesnt break, isnt temperamental and is comfortable to use.
Last year I went to Mozambique twice and had to travel with hand luggage only - so I borrowed everything except a wetsuit and mask. That happens fairly often.
I drink copious amounts of water before diving and consequently do pee in my wetsuit regularly, though I dont like borrowing a suit and handing it back with added flavourings.

Wetsuit
Good, safe diving begins with comfort, and the one thing Im fussy about is my wetsuit. Staring at a coral head on the fourth dive of the day doesnt generate a lot of body heat, and I gave up wearing a shortie years ago.
Ive tried numerous brands, but the best solution for variable water temperatures is my full-length 3mm suit by Waterproof, with a rather slinky undersuit combination made by Fourth Element.
I was seduced by the Swedish design features of the Waterproof and the gender-specific tailoring - which includes what I call the codpiece.
Its a flattering shape, and I like the inner seals on the ankles and wrists with the zip-down outer cuffs. The padding on the knees is good, and the zip at the neck doesnt get in the way.
If the water is below about 22C I will also put on my Fourth Element farmer john - which is actually neutrally buoyant. I can even wear it with the matching long-sleeved top as a wetsuit when the water is warm, and it really does feel like a second skin. Am I sounding like Trinny and Susannah

Mask
My black Mares Lyrica was a gift about 12 years ago, from an instructor friend who said I was scaring the other divers with the amount of green and black mould growing in my clear silicone mask. The Lyrica is very comfortable, and they say the black skirt protects your eyes from glare. I keep the original mould-encrusted mask as a back-up.

BC
Its a Mares - but which model I cant remember, and the lettering has worn away. I bought it as a package deal with a regulator and console at a Dive Show before I went to live in Seychelles. I confess that the BC leaks a bit, but I havent got around to buying a new one.

Regulator
My original Mares reg served me well, so Ive stuck with the brand, though I find the servicing charges exorbitant at dive shops in the UK.
The current reg is an MR42 Abyss, with the smart metal mesh front. Its Bipass tube helps break up the current flow and prevents exponential free-flow.
That sounds impressive, but I really like the metal construction overall. When I was a divemaster my old reg got thrown around on boats an awful lot, but it never let me down.

Fins
My fins are decidedly low-tech - open-heel, putrid yellow, quite rigid Technisub Stratos. Fifteen years old, great for manoeuvrability, they bear a rather impressive scar from the bite of a titan triggerfish in Sipadan. When I lead a dive, people often say that the yellow fins are visible from a very long way away.
Touch wood, Ive never had to replace a fin strap.

Computer
Ive got a Suunto Vyper 2, and I like the fact that it has a user-replaceable battery. I resented paying for someone else to put a battery in my old Suunto Solution, which I keep as a back-up anyway.
The Solution is less cautious, but I always worry about what happens if the primary computer goes into an error mode on a liveaboard, and you have to miss a days diving as a precaution.

Extras
In my BC pocket I keep an orange safety sausage on a length of nylon line. I always have a dive-saver kit in my bag - spare mask and fin straps, cable ties etc, but apart from the O-rings Ive never had to use it.
I feel naked diving without my tank banger, a brass marine clip on a short lanyard. A quick knock on my air cylinder is an effective way of communicating with my buddy, and I can also use it to steady myself on a rock, rather than putting a hand down on the coral.
I dont have my own weightbelt, and I gave up on torches because I try not to use batteries on environmental grounds. I keep a small plastic bottle of vinegar in the kitbag in case of jellyfish stings.
My dive kitbag is an LL Bean mesh bag that lets the water drain out and has lasted for years.
It weighs almost nothing and lies flat inside my suitcase when I do take all my kit on a plane.